Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[service] add service.disableOpenCensusBridge gate #10542

Merged
merged 4 commits into from
Jul 9, 2024
Merged

[service] add service.disableOpenCensusBridge gate #10542

merged 4 commits into from
Jul 9, 2024

Conversation

codeboten
Copy link
Contributor

This feature gate allows end users to re-enable the opencensus bridge if there's a need for it. This preceeds #10406 and will be taken out of draft once open-telemetry/opentelemetry-collector-contrib#29867 is completed.

Related to #10414

@codeboten codeboten mentioned this pull request Jul 4, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.33%. Comparing base (b9570b4) to head (0cf90e3).
Report is 1 commits behind head on main.

Files Patch % Lines
service/internal/proctelemetry/config.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10542      +/-   ##
==========================================
- Coverage   92.34%   92.33%   -0.01%     
==========================================
  Files         393      395       +2     
  Lines       18660    18673      +13     
==========================================
+ Hits        17231    17242      +11     
- Misses       1069     1070       +1     
- Partials      360      361       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten marked this pull request as ready for review July 8, 2024 18:59
@codeboten codeboten requested review from a team and mx-psi July 8, 2024 18:59
@codeboten
[service] add service.disableOpenCensusBridge gate
eb18f07 
This feature gate allows end users to re-enable the opencensus bridge if there's a need for it. This preceeds open-telemetry#10406 and will be taken out of draft once open-telemetry/opentelemetry-collector-contrib#29867 is completed.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/census-feature-gate branch from b86baf5 to eb18f07 Compare July 8, 2024 19:03
mx-psi
mx-psi approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have an info level log about this on initialization?

@codeboten
Copy link
Contributor Author

Would it make sense to have an info level log about this on initialization?

@mx-psi you mean a warning about opencensus telemetry being disabled?

@mx-psi
Copy link
Member

mx-psi commented Jul 8, 2024

Would it make sense to have an info level log about this on initialization?

@mx-psi you mean a warning about opencensus telemetry being disabled?

Yep. Some people don't like having a warning that is not actionable, so that's why I was proposing an info-level log

@codeboten
Copy link
Contributor Author

Would it make sense to have an info level log about this on initialization?

@mx-psi you mean a warning about opencensus telemetry being disabled?

Yep. Some people don't like having a warning that is not actionable, so that's why I was proposing an info-level log

Right, sorry i meant a "log" not a "warning" about opencensus telemetry being disabled :) sure i can add that

dmathieu and others added 2 commits July 9, 2024 10:44
@dmathieu @mx-psi @codeboten
Add consumer profiles (open-telemetry#10464)
9bfbc47 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This adds profiles support for consumers.


<!-- Issue number if applicable -->
#### Link to tracking issue
Based on the discussion in open-telemetry#10375.

---------

Co-authored-by: Pablo Baeyens <[email protected]>
@codeboten
add info log about opencensus bridge being disabled
0cf90e3 
Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten merged commit 650ac0b into open-telemetry:main Jul 9, 2024
48 of 49 checks passed
@codeboten codeboten deleted the codeboten/census-feature-gate branch July 9, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Collector: v1
Archived in project
Milestone
v0.105.0
Development

Successfully merging this pull request may close these issues.
3 participants
@codeboten @mx-psi @dmathieu